npawar opened a new pull request #5349:
URL: https://github.com/apache/incubator-pinot/pull/5349


   An item for project https://github.com/apache/incubator-pinot/issues/2756
   
   When timeFieldSpec gets deprecated in favor of DateTimeFieldSpec, one of the 
changes will be in the `SchemaBuilder` class. `SchemaBuilder` is used only in 
tests (not sure if external integrations use it). 
   SchemaBuilder has ~10 methods to `addTime`. These will be replaced with 
`addDateTime` (barring a few places where we intentionally want to add TIME to 
test that we get DATE_TIME.)
   
   Removing most of the addTime methods, keeping only
   1) `addTime(incomingGranularitySpec, outgoingGranularitySpec)`
   This will help when making the code change to dateTimeFieldSpec. 
   
   These above method gets replaced by
   1) `addDateTime(name, dataType, format, granularity)` // basic fields
   2) `addDateTime(name, dataType, format, granularity, defaultNullValue, 
transformFunction) `// advanced fields


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to