npawar commented on a change in pull request #5349:
URL: https://github.com/apache/incubator-pinot/pull/5349#discussion_r422296180
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -451,118 +452,87 @@ public SchemaBuilder setSchemaName(String schemaName) {
return this;
}
+ /**
+ * Add single value dimensionFieldSpec with basic fields
+ */
public SchemaBuilder addSingleValueDimension(String dimensionName,
DataType dataType) {
_schema.addField(new DimensionFieldSpec(dimensionName, dataType, true));
return this;
}
+ /**
+ * Add single value dimensionFieldSpec with basic fields plus
defaultNullValue
+ */
public SchemaBuilder addSingleValueDimension(String dimensionName,
DataType dataType, Object defaultNullValue) {
_schema.addField(new DimensionFieldSpec(dimensionName, dataType, true,
defaultNullValue));
return this;
}
+ /**
+ * Add multi value dimensionFieldSpec with basic fields
+ */
public SchemaBuilder addMultiValueDimension(String dimensionName, DataType
dataType) {
_schema.addField(new DimensionFieldSpec(dimensionName, dataType, false));
return this;
}
+ /**
+ * Add single value dimensionFieldSpec with basic fields plus
defaultNullValue
+ */
public SchemaBuilder addMultiValueDimension(String dimensionName, DataType
dataType, Object defaultNullValue) {
_schema.addField(new DimensionFieldSpec(dimensionName, dataType, false,
defaultNullValue));
return this;
}
+ /**
+ * Add metricFieldSpec with basic fields
+ */
public SchemaBuilder addMetric(String metricName, DataType dataType) {
_schema.addField(new MetricFieldSpec(metricName, dataType));
return this;
}
+ /**
+ * Add metricFieldSpec with basic fields plus defaultNullValue
+ */
public SchemaBuilder addMetric(String metricName, DataType dataType,
Object defaultNullValue) {
_schema.addField(new MetricFieldSpec(metricName, dataType,
defaultNullValue));
return this;
}
- public SchemaBuilder addTime(String incomingName, TimeUnit
incomingTimeUnit, DataType incomingDataType) {
- _schema.addField(new TimeFieldSpec(incomingName, incomingDataType,
incomingTimeUnit));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, TimeUnit
incomingTimeUnit, DataType incomingDataType,
- Object defaultNullValue) {
- _schema.addField(new TimeFieldSpec(incomingName, incomingDataType,
incomingTimeUnit, defaultNullValue));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, TimeUnit
incomingTimeUnit, DataType incomingDataType,
- String outgoingName, TimeUnit outgoingTimeUnit, DataType
outgoingDataType) {
- _schema.addField(
- new TimeFieldSpec(incomingName, incomingDataType, incomingTimeUnit,
outgoingName, outgoingDataType,
- outgoingTimeUnit));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, TimeUnit
incomingTimeUnit, DataType incomingDataType,
- String outgoingName, TimeUnit outgoingTimeUnit, DataType
outgoingDataType, Object defaultNullValue) {
- _schema.addField(
- new TimeFieldSpec(incomingName, incomingDataType, incomingTimeUnit,
outgoingName, outgoingDataType,
- outgoingTimeUnit, defaultNullValue));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, int
incomingTimeUnitSize, TimeUnit incomingTimeUnit,
- DataType incomingDataType) {
- _schema.addField(new TimeFieldSpec(incomingName, incomingDataType,
incomingTimeUnitSize, incomingTimeUnit));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, int
incomingTimeUnitSize, TimeUnit incomingTimeUnit,
- DataType incomingDataType, Object defaultNullValue) {
- _schema.addField(
- new TimeFieldSpec(incomingName, incomingDataType,
incomingTimeUnitSize, incomingTimeUnit, defaultNullValue));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, int
incomingTimeUnitSize, TimeUnit incomingTimeUnit,
- DataType incomingDataType, String outgoingName, int
outgoingTimeUnitSize, TimeUnit outgoingTimeUnit,
- DataType outgoingDataType) {
- _schema.addField(
- new TimeFieldSpec(incomingName, incomingDataType,
incomingTimeUnitSize, incomingTimeUnit, outgoingName,
- outgoingDataType, outgoingTimeUnitSize, outgoingTimeUnit));
- return this;
- }
-
- public SchemaBuilder addTime(String incomingName, int
incomingTimeUnitSize, TimeUnit incomingTimeUnit,
- DataType incomingDataType, String outgoingName, int
outgoingTimeUnitSize, TimeUnit outgoingTimeUnit,
- DataType outgoingDataType, Object defaultNullValue) {
- _schema.addField(
- new TimeFieldSpec(incomingName, incomingDataType,
incomingTimeUnitSize, incomingTimeUnit, outgoingName,
- outgoingDataType, outgoingTimeUnitSize, outgoingTimeUnit,
defaultNullValue));
- return this;
- }
-
- public SchemaBuilder addTime(TimeGranularitySpec
incomingTimeGranularitySpec) {
- _schema.addField(new TimeFieldSpec(incomingTimeGranularitySpec));
- return this;
- }
-
- public SchemaBuilder addTime(TimeGranularitySpec
incomingTimeGranularitySpec, Object defaultNullValue) {
- _schema.addField(new TimeFieldSpec(incomingTimeGranularitySpec,
defaultNullValue));
- return this;
- }
-
+ /**
+ * Add timeFieldSpec with incoming and outgoing granularity spec
+ * TODO: This is deprecated in favor of addDateTime().
Review comment:
It was marked as Deprecated. But on second thought, I removed
Deprecated. This method is not deprecated yet. It'll be truly deprecated only
once we have. moved. As of now, we still want users to addTime for their main
time column
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]