Jackie-Jiang commented on a change in pull request #5400:
URL: https://github.com/apache/incubator-pinot/pull/5400#discussion_r426992905
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/reader/impl/v1/BaseChunkSingleValueReader.java
##########
@@ -75,7 +67,7 @@ public BaseChunkSingleValueReader(PinotDataBuffer
pinotDataBuffer) {
headerOffset += Integer.BYTES;
int dataHeaderStart = headerOffset;
- if (_version > 1) {
+ if (version > 1) {
Review comment:
It is not used anywhere, and IDE will have warning and can auto convert
it to local.
I don't see why this can affect version bump as long as you have the version
information inside the data buffer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
