Jackie-Jiang commented on a change in pull request #5400:
URL: https://github.com/apache/incubator-pinot/pull/5400#discussion_r426993371
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/readerwriter/impl/FixedByteSingleColumnSingleValueReaderWriter.java
##########
@@ -176,18 +173,15 @@ private int getBufferId(int row) {
private void addBuffer() {
LOGGER.info("Allocating {} bytes for: {}", _chunkSizeInBytes,
_allocationContext);
+ // NOTE: PinotDataBuffer is tracked in the PinotDataBufferMemoryManager.
No need to track it inside the class.
PinotDataBuffer buffer = _memoryManager.allocate(_chunkSizeInBytes,
_allocationContext);
- _dataBuffers.add(buffer);
+ _writers.add(
Review comment:
In `MutableSegmentImpl.destroy()` where memory manager is closed as the
last step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
