mcvsubbu opened a new pull request #5506:
URL: https://github.com/apache/incubator-pinot/pull/5506
- Changed StreamPartitionMsgOffset class to be an interface.
- Introduced a LongMsgOffsetFactory class that can be used for Kafka. Other
streams will need to provide their own factory to create offsets of
various types. Keeping LongMsgOffsetFactory in spi, so we can also use
it in tests. Alternative was to introduce this for each test, but implement
one in kafka that does the same thing.
- Introduced a new config 'stream.<type>.partition.offset.factory.class.name'
Stream providers need to set the offset factory class with this config key.
- All classes now use StreamPartitionMsgOffset instead of 'long', except for
cases where the offset is received from the stream or the offset is being
read or written to persistent zk metadata.
- Marked TODOs explicity on items still to be done to complete impleemntation
of generic offsets.
Issue #5359
## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document,
etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the
documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
