npawar commented on a change in pull request #5506:
URL: https://github.com/apache/incubator-pinot/pull/5506#discussion_r437112256
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -515,7 +519,8 @@ private void createNewSegmentZKMetadata(TableConfig
tableConfig, PartitionLevelS
newSegmentZKMetadata.setTableName(realtimeTableName);
newSegmentZKMetadata.setSegmentName(segmentName);
newSegmentZKMetadata.setCreationTime(creationTimeMs);
- newSegmentZKMetadata.setStartOffset(startOffset);
+ // TODO Issue 5953 Use string offset in the metadata
+
newSegmentZKMetadata.setStartOffset(Long.parseLong(startOffset.toString()));
Review comment:
will we introduce new methods for setting offset in the metadata? What
happens to old segments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
