siddharthteotia commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-pinot/pull/5635#discussion_r447155403
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentOrderBySingleValueQueriesTest.java
##########
@@ -165,7 +162,7 @@ public void testQueryOptions() {
new Object[]{query, results, numDocsScanned,
numEntriesScannedInFilter, numEntriesScannedPostFilter, numTotalDocs,
dataSchema});
// order by one of the group by columns DESC
- query = "SELECT sum(column1) FROM testTable GROUP BY column11 ORDER BY
column11 DESC";
+ query = "SELECT column11, sum(column1) FROM testTable GROUP BY column11
ORDER BY column11 DESC";
Review comment:
We should not change existing unit tests. I suggest to append to the
unit tests without changing the existing queries in existing tests otherwise we
will end up reducing the coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
