siddharthteotia commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-pinot/pull/5635#discussion_r447154238
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentOrderByMultiValueQueriesTest.java
##########
@@ -38,10 +38,7 @@
@Test(dataProvider = "orderByDataProvider")
public void testGroupByOrderByMVSQLResults(String query, List<Object[]>
expectedResults,
long expectedNumEntriesScannedPostFilter, DataSchema expectedDataSchema)
{
- Map<String, String> queryOptions = new HashMap<>(2);
Review comment:
I would recommend to not change existing unit tests to accommodate new
tests. It will reduce the coverage like in this case we were going via PQL
compiler path and we changed to test SQL.
We should simply add a new unit test or at least append to the unit test
without changing the existing queries in the existing unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
