kishoreg commented on a change in pull request #5641:
URL: https://github.com/apache/incubator-pinot/pull/5641#discussion_r450587383



##########
File path: 
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java
##########
@@ -191,6 +192,14 @@ public void 
setStarTreeIndexConfigs(List<StarTreeIndexConfig> starTreeIndexConfi
     _starTreeIndexConfigs = starTreeIndexConfigs;
   }
 
+  public boolean isAllowStarTreeCreationDuringSegmentLoad() {

Review comment:
       why do we need this config. can we put this at the cluster level or 
something?
   
   also, if we really need this, rename the variable to 
enableDynamicStarTreeCreation 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to