Jackie-Jiang commented on a change in pull request #5641:
URL: https://github.com/apache/incubator-pinot/pull/5641#discussion_r451114483
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/IndexLoadingConfig.java
##########
@@ -126,6 +128,18 @@ private void extractFromTableConfig(@Nonnull TableConfig
tableConfig) {
_onHeapDictionaryColumns.addAll(onHeapDictionaryColumns);
}
+ if (indexingConfig.isAllowStarTreeCreationDuringSegmentLoad()) {
+ List<StarTreeIndexConfig> starTreeIndexConfigs =
indexingConfig.getStarTreeIndexConfigs();
+ if (starTreeIndexConfigs != null) {
+ for (StarTreeIndexConfig starTreeIndexConfig : starTreeIndexConfigs) {
+
_starTreeV2BuilderConfigs.add(StarTreeV2BuilderConfig.fromIndexConfig(starTreeIndexConfig));
+ }
+ }
+ if (indexingConfig.isEnableDefaultStarTree()) {
+ _starTreeV2BuilderConfigs.add(null);
Review comment:
We used to use null as a placeholder for the default star-tree. Updated
the PR to pass the boolean field into the star-tree builder for readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
