Jackie-Jiang commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r488337421
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.processing.utils; + +import java.nio.ByteBuffer; +import java.util.Arrays; +import org.apache.avro.Schema; +import org.apache.avro.SchemaBuilder; +import org.apache.avro.generic.GenericData; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.readers.GenericRow; + + +/** + * Helper util methods for SegmentProcessorFramework + */ +public final class SegmentProcessorUtils { + + private SegmentProcessorUtils() { + } + + /** + * Convert a GenericRow to an avro GenericRecord + */ + public static GenericData.Record convertGenericRowToAvroRecord(GenericRow genericRow, + GenericData.Record reusableRecord) { + for (String field : genericRow.getFieldToValueMap().keySet()) { Review comment: The value in `fieldToValueMap` should be the default value if the original value is `null`. IMO we should put `null` instead of default value in the `GenericData.Record` so that the `null` values can be populated to the new segment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
