mayankshriv opened a new pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044
The existing implementation of Broker reduce phase is single-threaded.
For group-by queries where large response are being sent back from multiple
servers,
this could become a bottlenect.
Given that brokers are generally light on CPU usage, making the reduce phase
multi-threaded would be a good idea to boost performance. This PR adds a
multi-threaded
implementation for the Group-By reducer for SQL.
- Added an executor service in BrokerReduceService that can be used by the
reduce phase.
- In this PR, the executor service defaults to have a single thread, until
the performance
impact can be studied under various conditions (eg high qps, where brokers
have higher
CPU usage).
- Added a broker side config to specify the number of threads to be used for
reduce phase.
`pinot.broker.num.reduce.threads`
- For testing, explicitly sets num threads to reduce to be > 1 to ensure
functional
correctness is tested.
## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document,
etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the
documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
