kishoreg commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r493022384
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -161,6 +161,10 @@
public static final double DEFAULT_BROKER_MIN_RESOURCE_PERCENT_FOR_START =
100.0;
public static final String CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE =
"pinot.broker.enable.query.limit.override";
+ // Config for number of threads to use for Broker reduce-phase.
+ public static final String CONFIG_OF_NUM_REDUCE_THREADS =
"pinot.broker.num.reduce.threads";
+ public static final int DEFAULT_NUM_REDUCE_THREADS = 1; // TBD: Change to
a more appropriate default (eg numCores).
Review comment:
This config is right but the implementation can be changed. This should
be something similar to what we have in combine operator - Executor pool is
cached or capped at a high number based on the number of cores. But the number
of callables we create be based on this config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
