npawar commented on pull request #6107: URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703889578
Along with this, I think we also need to make APPEND the default? I remember there were some retention related issues. From retention manager ``` String segmentPushType = validationConfig.getSegmentPushType(); if (tableConfig.getTableType() == TableType.OFFLINE && !"APPEND".equalsIgnoreCase(segmentPushType)) { LOGGER.info("Segment push type is not APPEND for table: {}, skip", tableNameWithType); return; } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org