jackjlli commented on pull request #6107: URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703938464
@icefury71 The 4th item I pasted above is the one we should be cautious about: https://github.com/apache/incubator-pinot/blob/540853d786c9e4b4bb27bf4bbc6fa73837ff1bc3/pinot-core/src/main/java/org/apache/pinot/core/segment/name/NormalizedDateSegmentNameGenerator.java#L53 The boolean value depends on whether the push type is shown as `APPEND` in the table config. If it's missing or it's REFRESH, (or it's mis-spelled), the behavior will be different. In this case, the missing pushType behavior is the same as `REFRESH` push type, which violates your default assumption. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
