chenboat commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r502743152
##########
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##########
@@ -80,6 +80,18 @@ public void testFieldSpec() {
Assert.assertEquals(fieldSpec1.hashCode(), fieldSpec2.hashCode());
Assert.assertEquals(fieldSpec1.getDefaultNullValue(), "false");
+ // Single-value boolean type dimension field with max length and default
null value.
+ fieldSpec1 = new DimensionFieldSpec();
+ fieldSpec1.setName("svDimension");
+ fieldSpec1.setDataType(BOOLEAN);
+ fieldSpec1.setDefaultNullValue(false);
+ fieldSpec1.setMaxLength(20000);
Review comment:
@deemoliu The maxLength should only be applied to String field. The
method names in Schema.java should reflect this as well. i.e., the method name
should be addStringMetric().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
