chenboat commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503563222
##########
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##########
@@ -80,6 +80,18 @@ public void testFieldSpec() {
Assert.assertEquals(fieldSpec1.hashCode(), fieldSpec2.hashCode());
Assert.assertEquals(fieldSpec1.getDefaultNullValue(), "false");
+ // Single-value boolean type dimension field with max length and default
null value.
+ fieldSpec1 = new DimensionFieldSpec();
+ fieldSpec1.setName("svDimension");
+ fieldSpec1.setDataType(BOOLEAN);
+ fieldSpec1.setDefaultNullValue(false);
+ fieldSpec1.setMaxLength(20000);
Review comment:
It looks like the doc is not in sync with the code. The code is usually
the source of truth. For this PR, I think the update to METRICS column can be
skipped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
