sajjad-moradi commented on a change in pull request #6129:
URL: https://github.com/apache/incubator-pinot/pull/6129#discussion_r503461466
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -157,20 +181,27 @@ fi
# Setup initial cluster with olderCommit and do rolling upgrade
startServices "$oldTargetDir"
-sleep 20
+#$COMPAT_TESTER pre-controller-upgrade.yaml
Review comment:
I'm not sure why 20 seconds sleep was chosen in the first place, but
does replacing it with running compat_tester mean the tests are going to take
20 seconds?
Also maybe it reads better if $COMPAT_TESTER is replaced with a function
call, something like runCompatiblityTests, which is more consistent with
startService, startService, ... here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
