mcvsubbu commented on a change in pull request #6129:
URL: https://github.com/apache/incubator-pinot/pull/6129#discussion_r508034672
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -157,20 +181,27 @@ fi
# Setup initial cluster with olderCommit and do rolling upgrade
startServices "$oldTargetDir"
-sleep 20
+#$COMPAT_TESTER pre-controller-upgrade.yaml
Review comment:
Removed the sleep. It should not be needed.
Replacing with a function call may be fine, but we still have to check the
return from that function. I have added the status check now. Let it be like
this for now, until we add more meat to it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
