npawar commented on a change in pull request #6124:
URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506777945
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
##########
@@ -62,16 +62,35 @@ private MinionConstants() {
public static final String MERGED_SEGMENT_NAME_KEY =
"mergedSegmentNameKey";
}
+ /**
+ * Creates segments for the OFFLINE table, using completed segments from the
corresponding REALTIME table
+ */
public static class RealtimeToOfflineSegmentsTask {
public static final String TASK_TYPE = "realtimeToOfflineSegmentsTask";
- // window
+
+ /**
+ * The time window size for the task.
+ * e.g. if set to "1d", then task is scheduled to run for a 1 day window
+ */
+ public static final String BUCKET_TIME_PERIOD_KEY = "bucketTimePeriod";
+ /**
+ * The time period to wait before picking segments for this task
+ * e.g. if set to "2d", no task will be scheduled for a time window
younger than 2 days
+ */
+ public static final String BUFFER_TIME_PERIOD_KEY = "bufferTimePeriod";
+ /**
+ * Config to manually provide start time for the very first task scheduled.
+ * In the absence of this config, the very first window start is
calculated as min(start time of all completed segments)
+ */
+ public static final String START_TIME_MILLIS_KEY = "startTimeMillis";
Review comment:
Probably not needed. Removed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
