npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r508945680
########## File path: pinot-common/src/main/java/org/apache/pinot/common/minion/MinionTaskMetadataUtils.java ########## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.minion; + +import javax.annotation.Nullable; +import org.I0Itec.zkclient.exception.ZkException; +import org.apache.helix.AccessOption; +import org.apache.helix.ZNRecord; +import org.apache.helix.store.HelixPropertyStore; +import org.apache.pinot.common.metadata.ZKMetadataProvider; +import org.apache.zookeeper.data.Stat; + + +/** + * Helper methods to fetch/persist ZNRecord for minion task metadata + */ +public final class MinionTaskMetadataUtils { + + private MinionTaskMetadataUtils() { + + } + + /** + * Fetches the ZNRecord for the given minion task and tableName, from MINION_TASK_METADATA/taskName/tableNameWthType + */ + @Nullable + public static ZNRecord fetchMinionTaskMetadataZNRecord(HelixPropertyStore<ZNRecord> propertyStore, String taskType, + String tableNameWithType) { + String path = ZKMetadataProvider.constructPropertyStorePathForMinionTaskMetadata(taskType, tableNameWithType); + Stat stat = new Stat(); + ZNRecord znRecord = propertyStore.get(path, stat, AccessOption.PERSISTENT); + if (znRecord != null) { + znRecord.setVersion(stat.getVersion()); + } + return znRecord; + } + + /** + * Fetches the ZNRecord for realtimeToOfflineSegmentsTask for given tableNameWithType from MINION_TASK_METADATA/realtimeToOfflineSegmentsTask/tableNameWthType + * and converts it to a {@link RealtimeToOfflineSegmentsTaskMetadata} object + */ + @Nullable + public static RealtimeToOfflineSegmentsTaskMetadata getRealtimeToOfflineSegmentsTaskMetadata( + HelixPropertyStore<ZNRecord> propertyStore, String taskType, String tableNameWithType) { + ZNRecord znRecord = fetchMinionTaskMetadataZNRecord(propertyStore, taskType, tableNameWithType); + return znRecord != null ? RealtimeToOfflineSegmentsTaskMetadata.fromZNRecord(znRecord) : null; + } + + /** + * Persists the provided {@link RealtimeToOfflineSegmentsTaskMetadata} to MINION_TASK_METADATA/realtimeToOfflineSegmentsTask/tableNameWthType. + * Will fail if expectedVersion does not match. + * Set expectedVersion -1 to override version check. + */ + public static void persistRealtimeToOfflineSegmentsTaskMetadata(HelixPropertyStore<ZNRecord> propertyStore, + String taskType, RealtimeToOfflineSegmentsTaskMetadata realtimeToOfflineSegmentsTaskMetadata, Review comment: MinionConstants is not accessible here. And I didn't want to have static variable String for it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
