Jackie-Jiang commented on pull request #6153:
URL: https://github.com/apache/incubator-pinot/pull/6153#issuecomment-712484759


   > I see. Then we need to look at the `timeColumnName` of table config to 
determine the primary.
   
   IMO, we don't need to validate that primary key does not contain time column 
(I can see a valid dedup use case that needs such setting). We can validate 
that all the primary key columns exist in the schema.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to