yupeng9 commented on a change in pull request #6153:
URL: https://github.com/apache/incubator-pinot/pull/6153#discussion_r508188508
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/SchemaUtils.java
##########
@@ -92,6 +93,8 @@ public static void validate(Schema schema) {
"Exception in getting arguments for transform function '" +
transformFunction + "' for column '"
+ column + "'", e);
}
+ } else {
+ primaryKeyColumnCandidates.add(column);
Review comment:
we can remove this constraint, though I feel it shall be very rare for
the transformed column to be the primary key
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -265,6 +265,12 @@ protected static void validateUpsertConfig(TableConfig
tableConfig, Schema schem
tableConfig.getRoutingConfig() != null &&
RoutingConfig.REPLICA_GROUP_INSTANCE_SELECTOR_TYPE
.equalsIgnoreCase(tableConfig.getRoutingConfig().getInstanceSelectorType()),
"Upsert table must use replica-group (i.e. replicaGroup) based
routing");
+ // no startree index
+ if (tableConfig.getIndexingConfig() != null &&
tableConfig.getIndexingConfig().getStarTreeIndexConfigs() != null) {
Review comment:
why? when both are null, this check is noop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
