Jackie-Jiang commented on a change in pull request #6176:
URL: https://github.com/apache/incubator-pinot/pull/6176#discussion_r510438707
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/BaseImmutableDictionary.java
##########
@@ -81,6 +80,31 @@ public int indexOf(String stringValue) {
return (index >= 0) ? index : NULL_VALUE_INDEX;
}
+ @Override
+ public IntSet getDictIdsInRange(String lower, String upper, boolean
includeLower, boolean includeUpper) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public int compare(int dictId1, int dictId2) {
+ return Integer.compare(dictId1, dictId2);
+ }
+
+ @Override
+ public Comparable getMinVal() {
+ return (Comparable) get(0);
+ }
+
+ @Override
+ public Comparable getMaxVal() {
+ return (Comparable) get(_length - 1);
+ }
+
+ @Override
+ public Object getSortedValues() {
+ throw new UnsupportedOperationException();
Review comment:
Added the note: This method is for the stats collection phase when
sealing the consuming segment, so not required for regular immutable dictionary
within the immutable segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
