chenboat commented on a change in pull request #6176: URL: https://github.com/apache/incubator-pinot/pull/6176#discussion_r510439147
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/Dictionary.java ########## @@ -40,14 +42,52 @@ */ DataType getValueType(); + /** + * Returns the number of values in the dictionary. + */ int length(); /** * Returns the index of the string representation of the value in the dictionary, or {@link #NULL_VALUE_INDEX} (-1) if - * the value does not exist. This API is for cross-type predicate evaluation. + * the value does not exist. This method is for the cross-type predicate evaluation. */ int indexOf(String stringValue); + /** + * Returns the insertion index of the string representation of the value in the dictionary. This method follows the + * same behavior as in {@link Arrays#binarySearch(Object[], Object)}. All sorted dictionary should support this Review comment: NIT: dictionary-> dictionaries ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org