fx19880617 commented on a change in pull request #6272:
URL: https://github.com/apache/incubator-pinot/pull/6272#discussion_r525642646
##########
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##########
@@ -72,17 +70,19 @@
public static final String SECRET_KEY = "secretKey";
public static final String REGION = "region";
public static final String ENDPOINT = "endpoint";
+ public static final String DISABLE_ACL = "disableAcl";
private static final Logger LOGGER =
LoggerFactory.getLogger(S3PinotFS.class);
private static final String DELIMITER = "/";
public static final String S3_SCHEME = "s3://";
private S3Client _s3Client;
+ private Boolean disableAcl = true;
@Override
public void init(PinotConfiguration config) {
Preconditions.checkArgument(!isNullOrEmpty(config.getProperty(REGION)));
String region = config.getProperty(REGION);
-
+ disableAcl = config.getProperty(DISABLE_ACL, true);
Review comment:
Create constant `DEFAULT_DISABLE_ACL=true` and use it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
