Aka-shi commented on a change in pull request #6272:
URL: https://github.com/apache/incubator-pinot/pull/6272#discussion_r525697186
##########
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##########
@@ -72,17 +70,19 @@
public static final String SECRET_KEY = "secretKey";
public static final String REGION = "region";
public static final String ENDPOINT = "endpoint";
+ public static final String DISABLE_ACL = "disableAcl";
private static final Logger LOGGER =
LoggerFactory.getLogger(S3PinotFS.class);
private static final String DELIMITER = "/";
public static final String S3_SCHEME = "s3://";
private S3Client _s3Client;
+ private Boolean disableAcl = true;
Review comment:
If I don't set the default here, the test case fail because the `init`
method used to set this config and the method used in the test cases is
different. In the recent commit, I am also reusing this to set the default
value in `getProperty` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
