fx19880617 edited a comment on pull request #6271: URL: https://github.com/apache/incubator-pinot/pull/6271#issuecomment-729989881
> @fx19880617 While supporting env variable seems good for local deployments, I am unsure how that works for real prod deployments. How do we propagate the credentials to all participants? Or do they query the controller each time? > > I am approving the env variable support change. But should we explore using Docker secrets instead, for storing credentials? yes, typically for prod env, those credentials are either local on the machine, and we can read it as env variable. For deployment on k8s, we can create a secret and set it as environment variables when we start the container. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
