npawar commented on pull request #6271:
URL: https://github.com/apache/incubator-pinot/pull/6271#issuecomment-730043495
> > This is going to create some issues in our validations that were
recently added. For example - we look for the index columns in the schema, but
user could have put an env variable. While this exact example is unlikely,
there could be other legit cases. We'll have to handle this in the validations
somehow.
>
> I feel those validations are fine as we may not want users to create a
table and let servers read those configs from env variables.
I didn't follow how it would be fine. This will result in users not being
able to create a table with env variables, or worse, table will get created
with incorrect config. In your example:
"realtime.segment.flush.threshold.time":
"${REALTIME_SEGMENT_FLUSH_THRESHOD_TIME:12h}"
This will fail validation, and then we'll end up setting a default value of
5m.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
