kishoreg commented on a change in pull request #6322:
URL: https://github.com/apache/incubator-pinot/pull/6322#discussion_r536492451
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1895,6 +1895,24 @@ public void toggleQueryQuotaStateForBroker(String
brokerInstanceName, String sta
return serverToSegmentsMap;
}
+ /**
+ * Returns a list of CONSUMING segments for the given realtime table.
+ */
+ public List<String> getConsumingSegments(String tableNameWithType) {
+ IdealState idealState =
_helixAdmin.getResourceIdealState(_helixClusterName, tableNameWithType);
+ if (idealState == null) {
+ throw new IllegalStateException("Ideal state does not exist for table: "
+ tableNameWithType);
+ }
+ List<String> consumingSegments = new ArrayList<>();
+ for (String segment : idealState.getPartitionSet()) {
+ Map<String, String> instanceStateMap =
idealState.getInstanceStateMap(segment);
+ if (instanceStateMap.containsValue(SegmentStateModel.CONSUMING)) {
+ consumingSegments.add(segment);
Review comment:
consumingSegments must be a set or it will containing duplicates
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1895,6 +1895,24 @@ public void toggleQueryQuotaStateForBroker(String
brokerInstanceName, String sta
return serverToSegmentsMap;
}
+ /**
+ * Returns a list of CONSUMING segments for the given realtime table.
+ */
+ public List<String> getConsumingSegments(String tableNameWithType) {
+ IdealState idealState =
_helixAdmin.getResourceIdealState(_helixClusterName, tableNameWithType);
+ if (idealState == null) {
+ throw new IllegalStateException("Ideal state does not exist for table: "
+ tableNameWithType);
+ }
+ List<String> consumingSegments = new ArrayList<>();
+ for (String segment : idealState.getPartitionSet()) {
+ Map<String, String> instanceStateMap =
idealState.getInstanceStateMap(segment);
+ if (instanceStateMap.containsValue(SegmentStateModel.CONSUMING)) {
Review comment:
might also need null check?
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
##########
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.controller.util;
+
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.google.common.collect.BiMap;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.concurrent.Executor;
+import org.apache.commons.httpclient.HttpConnectionManager;
+import org.apache.pinot.common.exception.InvalidConfigException;
+import org.apache.pinot.common.restlet.resources.SegmentConsumerInfo;
+import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
+import org.apache.pinot.spi.utils.JsonUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * This is a helper class that calls the server API endpoints to fetch
consuming segments info
+ * Only the servers returning success are returned by the method. For servers
returning errors (http error or otherwise),
+ * no entry is created in the return list
+ */
+public class ConsumingSegmentInfoReader {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ConsumingSegmentInfoReader.class);
+
+ private final Executor _executor;
+ private final HttpConnectionManager _connectionManager;
+ private final PinotHelixResourceManager _pinotHelixResourceManager;
+
+ public ConsumingSegmentInfoReader(Executor executor, HttpConnectionManager
connectionManager,
+ PinotHelixResourceManager helixResourceManager) {
+ _executor = executor;
+ _connectionManager = connectionManager;
+ _pinotHelixResourceManager = helixResourceManager;
+ }
+
+ /**
+ * This method retrieves the consuming segments info for a given realtime
table.
+ * @return a map of segmentName to the information about its consumer
+ */
+ public ConsumingSegmentsInfoMap getConsumingSegmentsInfo(String
tableNameWithType, int timeoutMs)
+ throws InvalidConfigException {
+ final Map<String, List<String>> serverToSegments =
+ _pinotHelixResourceManager.getServerToSegmentsMap(tableNameWithType);
+ BiMap<String, String> serverToEndpoints =
+
_pinotHelixResourceManager.getDataInstanceAdminEndpoints(serverToSegments.keySet());
+
+ // Gets info for segments with LLRealtimeSegmentDataManager found in the
table data manager
+ Map<String, List<SegmentConsumerInfo>> serverToSegmentConsumerInfoMap =
+ getConsumingSegmentsInfoFromServers(tableNameWithType,
serverToEndpoints, timeoutMs);
+ TreeMap<String, List<ConsumingSegmentInfo>> consumingSegmentInfoMap = new
TreeMap<>();
+ for (Map.Entry<String, List<SegmentConsumerInfo>> entry :
serverToSegmentConsumerInfoMap.entrySet()) {
+ String serverName = entry.getKey();
+ for (SegmentConsumerInfo info : entry.getValue()) {
+ consumingSegmentInfoMap.computeIfAbsent(info.getSegmentName(), k ->
new ArrayList<>())
+ .add(new ConsumingSegmentInfo(serverName, info.getConsumerState(),
info.getPartitionToOffset()));
+ }
+ }
+ // Segments which are in CONSUMING state but found no consumer on the
server
+ List<String> consumingSegments =
_pinotHelixResourceManager.getConsumingSegments(tableNameWithType);
+ consumingSegments.forEach(c -> consumingSegmentInfoMap.putIfAbsent(c,
Collections.emptyList()));
+ return new ConsumingSegmentsInfoMap(consumingSegmentInfoMap);
+ }
+
+ /**
+ * This method makes a MultiGet call to all servers to get the consuming
segments info.
+ * @return servers queried and a list of consumer status information for
consuming segments on that server
+ */
+ private Map<String, List<SegmentConsumerInfo>>
getConsumingSegmentsInfoFromServers(String tableNameWithType,
+ BiMap<String, String> serverToEndpoints, int timeoutMs) {
+ LOGGER.info("Reading consuming segment info from servers: {} for table:
{}", serverToEndpoints.keySet(),
+ tableNameWithType);
+
+ List<String> serverUrls = new ArrayList<>(serverToEndpoints.size());
+ BiMap<String, String> endpointsToServers = serverToEndpoints.inverse();
+ for (String endpoint : endpointsToServers.keySet()) {
+ String consumingSegmentInfoURI = generateServerURL(tableNameWithType,
endpoint);
+ serverUrls.add(consumingSegmentInfoURI);
+ }
+
+ CompletionServiceHelper completionServiceHelper =
+ new CompletionServiceHelper(_executor, _connectionManager,
endpointsToServers);
+ CompletionServiceHelper.CompletionServiceResponse serviceResponse =
+ completionServiceHelper.doMultiGetRequest(serverUrls,
tableNameWithType, timeoutMs);
+ Map<String, List<SegmentConsumerInfo>> serverToConsumingSegmentInfoList =
new HashMap<>();
+ int failedParses = 0;
+ for (Map.Entry<String, String> streamResponse :
serviceResponse._httpResponses.entrySet()) {
+ try {
+ List<SegmentConsumerInfo> segmentConsumerInfos =
+ JsonUtils.stringToObject(streamResponse.getValue(), new
TypeReference<List<SegmentConsumerInfo>>() {
+ });
+ serverToConsumingSegmentInfoList.put(streamResponse.getKey(),
segmentConsumerInfos);
+ } catch (IOException e) {
+ failedParses++;
+ LOGGER.error("Unable to parse server {} response due to an error: ",
streamResponse.getKey(), e);
+ }
+ }
+ if (failedParses != 0) {
+ LOGGER.warn("Failed to parse {} / {} segment size info responses from
servers.", failedParses, serverUrls.size());
+ }
+ return serverToConsumingSegmentInfoList;
+ }
+
+ private String generateServerURL(String tableNameWithType, String endpoint) {
+ return String.format("http://%s/tables/%s/consumingSegmentsInfo";,
endpoint, tableNameWithType);
+ }
+
+ /**
+ * Map containing all consuming segments and their status information
+ */
+ @JsonIgnoreProperties(ignoreUnknown = true)
+ static public class ConsumingSegmentsInfoMap {
+ public TreeMap<String, List<ConsumingSegmentInfo>>
_segmentToConsumingInfoMap;
+
+ public ConsumingSegmentsInfoMap(
+ @JsonProperty("segmentToConsumingInfoMap") TreeMap<String,
List<ConsumingSegmentInfo>> segmentToConsumingInfoMap) {
+ this._segmentToConsumingInfoMap = segmentToConsumingInfoMap;
+ }
+ }
+
+ /**
+ * Contains all the information about a consuming segment
+ */
+ @JsonIgnoreProperties(ignoreUnknown = true)
Review comment:
can we add a lastConsumedTimestamp?
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
##########
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.controller.util;
+
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.google.common.collect.BiMap;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.concurrent.Executor;
+import org.apache.commons.httpclient.HttpConnectionManager;
+import org.apache.pinot.common.exception.InvalidConfigException;
+import org.apache.pinot.common.restlet.resources.SegmentConsumerInfo;
+import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
+import org.apache.pinot.spi.utils.JsonUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * This is a helper class that calls the server API endpoints to fetch
consuming segments info
+ * Only the servers returning success are returned by the method. For servers
returning errors (http error or otherwise),
+ * no entry is created in the return list
+ */
+public class ConsumingSegmentInfoReader {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ConsumingSegmentInfoReader.class);
+
+ private final Executor _executor;
+ private final HttpConnectionManager _connectionManager;
+ private final PinotHelixResourceManager _pinotHelixResourceManager;
+
+ public ConsumingSegmentInfoReader(Executor executor, HttpConnectionManager
connectionManager,
+ PinotHelixResourceManager helixResourceManager) {
+ _executor = executor;
+ _connectionManager = connectionManager;
+ _pinotHelixResourceManager = helixResourceManager;
+ }
+
+ /**
+ * This method retrieves the consuming segments info for a given realtime
table.
+ * @return a map of segmentName to the information about its consumer
+ */
+ public ConsumingSegmentsInfoMap getConsumingSegmentsInfo(String
tableNameWithType, int timeoutMs)
+ throws InvalidConfigException {
+ final Map<String, List<String>> serverToSegments =
+ _pinotHelixResourceManager.getServerToSegmentsMap(tableNameWithType);
+ BiMap<String, String> serverToEndpoints =
+
_pinotHelixResourceManager.getDataInstanceAdminEndpoints(serverToSegments.keySet());
+
+ // Gets info for segments with LLRealtimeSegmentDataManager found in the
table data manager
+ Map<String, List<SegmentConsumerInfo>> serverToSegmentConsumerInfoMap =
+ getConsumingSegmentsInfoFromServers(tableNameWithType,
serverToEndpoints, timeoutMs);
+ TreeMap<String, List<ConsumingSegmentInfo>> consumingSegmentInfoMap = new
TreeMap<>();
+ for (Map.Entry<String, List<SegmentConsumerInfo>> entry :
serverToSegmentConsumerInfoMap.entrySet()) {
+ String serverName = entry.getKey();
+ for (SegmentConsumerInfo info : entry.getValue()) {
+ consumingSegmentInfoMap.computeIfAbsent(info.getSegmentName(), k ->
new ArrayList<>())
+ .add(new ConsumingSegmentInfo(serverName, info.getConsumerState(),
info.getPartitionToOffset()));
+ }
+ }
+ // Segments which are in CONSUMING state but found no consumer on the
server
+ List<String> consumingSegments =
_pinotHelixResourceManager.getConsumingSegments(tableNameWithType);
+ consumingSegments.forEach(c -> consumingSegmentInfoMap.putIfAbsent(c,
Collections.emptyList()));
+ return new ConsumingSegmentsInfoMap(consumingSegmentInfoMap);
+ }
+
+ /**
+ * This method makes a MultiGet call to all servers to get the consuming
segments info.
+ * @return servers queried and a list of consumer status information for
consuming segments on that server
+ */
+ private Map<String, List<SegmentConsumerInfo>>
getConsumingSegmentsInfoFromServers(String tableNameWithType,
+ BiMap<String, String> serverToEndpoints, int timeoutMs) {
+ LOGGER.info("Reading consuming segment info from servers: {} for table:
{}", serverToEndpoints.keySet(),
+ tableNameWithType);
+
+ List<String> serverUrls = new ArrayList<>(serverToEndpoints.size());
+ BiMap<String, String> endpointsToServers = serverToEndpoints.inverse();
+ for (String endpoint : endpointsToServers.keySet()) {
+ String consumingSegmentInfoURI = generateServerURL(tableNameWithType,
endpoint);
+ serverUrls.add(consumingSegmentInfoURI);
+ }
+
+ CompletionServiceHelper completionServiceHelper =
+ new CompletionServiceHelper(_executor, _connectionManager,
endpointsToServers);
+ CompletionServiceHelper.CompletionServiceResponse serviceResponse =
+ completionServiceHelper.doMultiGetRequest(serverUrls,
tableNameWithType, timeoutMs);
+ Map<String, List<SegmentConsumerInfo>> serverToConsumingSegmentInfoList =
new HashMap<>();
+ int failedParses = 0;
+ for (Map.Entry<String, String> streamResponse :
serviceResponse._httpResponses.entrySet()) {
+ try {
+ List<SegmentConsumerInfo> segmentConsumerInfos =
+ JsonUtils.stringToObject(streamResponse.getValue(), new
TypeReference<List<SegmentConsumerInfo>>() {
+ });
+ serverToConsumingSegmentInfoList.put(streamResponse.getKey(),
segmentConsumerInfos);
+ } catch (IOException e) {
+ failedParses++;
+ LOGGER.error("Unable to parse server {} response due to an error: ",
streamResponse.getKey(), e);
+ }
+ }
+ if (failedParses != 0) {
+ LOGGER.warn("Failed to parse {} / {} segment size info responses from
servers.", failedParses, serverUrls.size());
+ }
+ return serverToConsumingSegmentInfoList;
+ }
+
+ private String generateServerURL(String tableNameWithType, String endpoint) {
+ return String.format("http://%s/tables/%s/consumingSegmentsInfo";,
endpoint, tableNameWithType);
+ }
+
+ /**
+ * Map containing all consuming segments and their status information
+ */
+ @JsonIgnoreProperties(ignoreUnknown = true)
+ static public class ConsumingSegmentsInfoMap {
+ public TreeMap<String, List<ConsumingSegmentInfo>>
_segmentToConsumingInfoMap;
+
+ public ConsumingSegmentsInfoMap(
+ @JsonProperty("segmentToConsumingInfoMap") TreeMap<String,
List<ConsumingSegmentInfo>> segmentToConsumingInfoMap) {
+ this._segmentToConsumingInfoMap = segmentToConsumingInfoMap;
+ }
+ }
+
+ /**
+ * Contains all the information about a consuming segment
+ */
+ @JsonIgnoreProperties(ignoreUnknown = true)
+ static public class ConsumingSegmentInfo {
+ public String _serverName;
+ public String _consumerState;
+ public Map<String, String> _partitionToOffset;
+
+ public ConsumingSegmentInfo(@JsonProperty("serverName") String serverName,
+ @JsonProperty("consumerState") String consumerState,
+ @JsonProperty("partitionToOffset") Map<String, String>
partitionToOffset) {
+ _serverName = serverName;
+ _consumerState = consumerState;
+ _partitionToOffset = partitionToOffset;
Review comment:
_partitionToOffsetMap ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
