zhangloo333 commented on a change in pull request #6568:
URL: https://github.com/apache/incubator-pinot/pull/6568#discussion_r574014889
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/rootcause-custom-baseline/component.js
##########
@@ -26,10 +22,11 @@ export default Component.extend({
selectedBaselineType: 'Unit over x units',
+ // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
baselineTypes: [UNIT_OVER_UNIT, MEAN_UNIT, MEDIAN_UNIT, MAX_UNIT, MIN_UNIT],
selectedTimeUnit: 'Week',
-
+ // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
Review comment:
I have checked that nearly all components have objects and arrays
assigned to the property in the ember class. Because we will refactor all ember
classes to native classes after upgrading to ember octan, it is safe to assign
objects to fields in the native class (see
[here](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/avoid-leaking-state-in-ember-objects.md)).
I make a trade-off for skipping the ember object check currently and refactor
all after migrating to ember octane. it will reduce repetitive work. We can
club them in a constant folder to reduce some duplicate snippets or make it a
constant in the file. Let me know your opinions on the plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
