tejasajmera commented on a change in pull request #6568:
URL: https://github.com/apache/incubator-pinot/pull/6568#discussion_r574768345
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/rootcause-custom-baseline/component.js
##########
@@ -26,10 +22,11 @@ export default Component.extend({
selectedBaselineType: 'Unit over x units',
+ // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
baselineTypes: [UNIT_OVER_UNIT, MEAN_UNIT, MEDIAN_UNIT, MAX_UNIT, MIN_UNIT],
selectedTimeUnit: 'Week',
-
+ // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
Review comment:
I am not sure we will be updating the native components any time soon. I
believe we want to update them as we go considering that the codebase is pretty
sizable. But yeah since it is okay for a class to be having this and since each
component ends up creating its own instance, the state should not be leaked. We
can keep it the way it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
