sajjad-moradi commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r589966089
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimatorTest.java
##########
@@ -41,20 +43,20 @@
public void testSegmentGenerator() throws Exception {
runTest("memory_estimation/schema-with-metadata.json", metadata -> {
assertEquals(extract(metadata, "segment.total.docs = (\\d+)"), "100000");
- assertEquals(extract(metadata, "column.colInt.cardinality = (\\d+)"),
"100");
- assertEquals(extract(metadata, "column.colIntMV.cardinality = (\\d+)"),
"150");
- assertEquals(extract(metadata, "column.colFloat.cardinality = (\\d+)"),
"200");
- assertEquals(extract(metadata, "column.colFloatMV.cardinality =
(\\d+)"), "250");
- assertEquals(extract(metadata, "column.colString.cardinality = (\\d+)"),
"300");
- assertEquals(extract(metadata, "column.colStringMV.cardinality =
(\\d+)"), "350");
- assertEquals(extract(metadata, "column.colBytes.cardinality = (\\d+)"),
"400");
- assertEquals(extract(metadata, "column.colLong.cardinality = (\\d+)"),
"500");
- assertEquals(extract(metadata, "column.colLongMV.cardinality = (\\d+)"),
"550");
- assertEquals(extract(metadata, "column.colDouble.cardinality = (\\d+)"),
"600");
- assertEquals(extract(metadata, "column.colDoubleMV.cardinality =
(\\d+)"), "650");
- assertEquals(extract(metadata, "column.colDoubleMetric.cardinality =
(\\d+)"), "700");
- assertEquals(extract(metadata, "column.colFloatMetric.cardinality =
(\\d+)"), "800");
- assertEquals(extract(metadata, "column.colTime.cardinality = (\\d+)"),
"900");
+ assertEquals(extract(metadata, "column.colInt.cardinality = (\\d+)"),
"10");
Review comment:
The values here are generated randomly and probability of creating
distinct number of values as specified in cardinality metadata gets closer to
one if we increase the number of rows and decrease the cardinality. Previous
values in the tests led to flaky results. Here I'm just making sure that the
test essentially never fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
