sajjad-moradi commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r589967956
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/RecommenderConstants.java
##########
@@ -80,6 +81,13 @@
public static final String ERROR_INVALID_QUERY = "Error: query not able to
parse, skipped";
}
+ public static class RealtimeProvisioningRule {
Review comment:
Here the constants are defined for RealtimeProvisiningRule. I'm not sure
adding comments makes it more clear than that. Some experts believe that we
should not put comments as much as we can and instead use descriptive names
unless there's no way around it. They believe that in code refactoring comments
don't get proper attention and easily become outdated.
Anyways, if you still think it's better to write something there, I can
simply add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
