mcvsubbu commented on pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#issuecomment-807233774
> @mqliang @mcvsubbu I'm suggesting putting integer ids so that we can deprecate keys if needed by skipping the id, similar to the `thrift` convention. Using ordinal to index across enum is not as flexible. We can also put the name as another field of the enum. I think we are saying the same thing. Have set of integers in no specific order that we can skip if not recognized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org