mqliang commented on pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#issuecomment-807254112
> I'm suggesting putting integer ids so that we can deprecate keys if needed by skipping the id, similar to the thrift convention. Getcha. Associate an ID(integer) with each enum ordinal. During serialization, use the ID as key, not ordinal. This way we can remove a key from enum if it's not used anymore. > Also suggest renaming it to MetadataKeys I name it as TrailerKeys since trailer may not only contains metadata KV pairs, but also contains some other data in future -- a metadata key must be a trailer key, but the opposite is not necessarily true. I am OK to rename it as MetadataKeys if we can accept it to call all data we put into the section in future as metadata. CC @mcvsubbu for more input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
