Jackie-Jiang commented on a change in pull request #6725:
URL: https://github.com/apache/incubator-pinot/pull/6725#discussion_r603577211
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##########
@@ -205,9 +205,10 @@ private static void
createLeadControllerResourceIfNeeded(String helixClusterName
if (resourceConfig == null) {
resourceConfig = new ResourceConfig(LEAD_CONTROLLER_RESOURCE_NAME);
}
- // Set RESOURCE_ENABLED to false if it's absent in resource config
- if (resourceConfig.getSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY)
== null) {
- resourceConfig.putSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY,
Boolean.FALSE.toString());
+ // Explicitly set RESOURCE_ENABLED to true
+ String leadControllerResourceEnabled =
resourceConfig.getSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY);
+ if (!Boolean.parseBoolean(leadControllerResourceEnabled)) {
Review comment:
We should only set this flag to true if it is not explicitly configured.
The current logic will ignore the current config and always override the config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
