mcvsubbu commented on a change in pull request #6725:
URL: https://github.com/apache/incubator-pinot/pull/6725#discussion_r603671962
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##########
@@ -205,10 +205,10 @@ private static void
createLeadControllerResourceIfNeeded(String helixClusterName
if (resourceConfig == null) {
resourceConfig = new ResourceConfig(LEAD_CONTROLLER_RESOURCE_NAME);
}
- // Set RESOURCE_ENABLED to false if it's absent in resource config
- if (resourceConfig.getSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY)
== null) {
- resourceConfig.putSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY,
Boolean.FALSE.toString());
- }
+ // Explicitly set RESOURCE_ENABLED to true, so that the lead controller
resource is always enabled.
+ // This is to help keep the behavior consistent in all clusters for better
maintenance.
+ // TODO: remove the logic of handling this config in both controller and
server in the next official release.
Review comment:
It is best if you identify all the code that needs to be removed, and
put a comment head saying "Remove this block of code once 0.8.0 release is
done" or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
