siddharthteotia commented on a change in pull request #6735:
URL: https://github.com/apache/incubator-pinot/pull/6735#discussion_r605206152
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java
##########
@@ -313,6 +315,24 @@ public void testDateTimeFieldSpec()
SchemaUtils.validate(pinotSchema);
}
+ @Test
+ public void testColumnNameValidation()
Review comment:
Also please add a comment stating that currently the test is only for
checking whitespaces. Later on if we add more validation on column names, we
can corresponding tests here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
