siddharthteotia commented on a change in pull request #6735:
URL: https://github.com/apache/incubator-pinot/pull/6735#discussion_r605221551
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java
##########
@@ -313,6 +315,42 @@ public void testDateTimeFieldSpec()
SchemaUtils.validate(pinotSchema);
}
+ /**
+ * Testcases for testing column name validation logic.
+ * Currently column name validation only checks no blank space in column
names. Should we add more validation on column
+ * names later on, we can corresponding tests here.
Review comment:
(nit) we can add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
