Jackie-Jiang commented on a change in pull request #7180:
URL: https://github.com/apache/incubator-pinot/pull/7180#discussion_r673560279
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskExecutor.java
##########
@@ -64,27 +57,29 @@
LOGGER.info("Starting task: {} with configs: {}", taskType, configs);
long startMillis = System.currentTimeMillis();
- Preconditions.checkState(
-
MergeType.CONCAT.name().equalsIgnoreCase(configs.get(MinionConstants.MergeRollupTask.MERGE_TYPE_KEY)),
- "Only 'CONCAT' mode is currently supported.");
-
String tableNameWithType = configs.get(MinionConstants.TABLE_NAME_KEY);
TableConfig tableConfig = getTableConfig(tableNameWithType);
Schema schema = getSchema(tableNameWithType);
- Map<String, AggregationFunctionType> aggregationTypes =
MergeRollupTaskUtils.getRollupAggregationTypes(configs);
- String numRecordsPerSegmentString =
configs.get(MinionConstants.MergeRollupTask.MAX_NUM_RECORDS_PER_SEGMENT);
-
SegmentProcessorConfig.Builder segmentProcessorConfigBuilder =
- new
SegmentProcessorConfig.Builder().setTableConfig(tableConfig).setSchema(schema)
- .setMergeType(MergeType.CONCAT);
- if (!aggregationTypes.isEmpty()) {
- segmentProcessorConfigBuilder.setAggregationTypes(aggregationTypes);
- }
- if (numRecordsPerSegmentString != null) {
- segmentProcessorConfigBuilder.setSegmentConfig(
- new
SegmentConfig.Builder().setMaxNumRecordsPerSegment(Integer.parseInt(numRecordsPerSegmentString)).build());
- }
+ new
SegmentProcessorConfig.Builder().setTableConfig(tableConfig).setSchema(schema);
+
+ // Time handler config
+ segmentProcessorConfigBuilder
+ .setTimeHandlerConfig(MergeTaskUtils.getTimeHandlerConfig(tableConfig,
schema, configs));
+
+ // Partitioner config
Review comment:
I see. The segment framework will always partition the data in case the
old segment is not properly partitioned. The overhead should be fairly low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
