Jackie-Jiang commented on a change in pull request #7180:
URL: https://github.com/apache/incubator-pinot/pull/7180#discussion_r673591624
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentConfig.java
##########
@@ -30,7 +30,7 @@
*/
@JsonIgnoreProperties(ignoreUnknown = true)
public class SegmentConfig {
- private static final int DEFAULT_MAX_NUM_RECORDS_PER_SEGMENT = 5_000_000;
+ public static final int DEFAULT_MAX_NUM_RECORDS_PER_SEGMENT = 5_000_000;
Review comment:
1M records per segment is usually too small. Here I'd prefer keeping the
existing behavior of 5M per segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
