jtao15 commented on a change in pull request #7260:
URL: https://github.com/apache/pinot/pull/7260#discussion_r684519143
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
##########
@@ -244,6 +247,9 @@
public static final String CONFIG_OF_QUERY_EXECUTOR_TIMEOUT =
"pinot.server.query.executor.timeout";
public static final String CONFIG_OF_QUERY_EXECUTOR_CLASS =
"pinot.server.query.executor.class";
public static final String CONFIG_OF_REQUEST_HANDLER_FACTORY_CLASS =
"pinot.server.requestHandlerFactory.class";
+ public static final String
CONFIG_OF_SERVER_SLOW_QUERY_LATENCY_THRESHOLD_MS =
+ "pinot.server.slow.query.latency.thresholdMs";
+ public static final long DEFAULT_SERVER_SLOW_QUERY_LATENCY_THRESHOLD_MS =
100L;
Review comment:
Maybe we should change the default value to a larger number `200ms` or
`300ms` perhaps. I checked my production use case, some server can have log
file size > 20G.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
