amrishlal commented on a change in pull request #7260:
URL: https://github.com/apache/pinot/pull/7260#discussion_r684651078
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
##########
@@ -54,16 +54,17 @@
public class InstanceRequestHandler extends
SimpleChannelInboundHandler<ByteBuf> {
private static final Logger LOGGER =
LoggerFactory.getLogger(InstanceRequestHandler.class);
- // TODO: make it configurable
- private static final int SLOW_QUERY_LATENCY_THRESHOLD_MS = 100;
+ private final long _slowQueryLatencyThresholdMs;
private final TDeserializer _deserializer = new TDeserializer(new
TCompactProtocol.Factory());
private final QueryScheduler _queryScheduler;
private final ServerMetrics _serverMetrics;
- public InstanceRequestHandler(QueryScheduler queryScheduler, ServerMetrics
serverMetrics) {
+ public InstanceRequestHandler(QueryScheduler queryScheduler, ServerMetrics
serverMetrics,
+ long slowQueryLatencyThresholdMs) {
Review comment:
I don't think it's a good idea to expose an internal variable like
`slowQueryLatencyThresholdMs` through constructor. This variable seems to be
polluting the namespace outside the class where it is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
