Jackie-Jiang commented on a change in pull request #7249:
URL: https://github.com/apache/pinot/pull/7249#discussion_r685587902
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -472,13 +474,15 @@ public SuccessResponse reloadSegmentDeprecated2(
@ApiOperation(value = "Reload all segments", notes = "Reload all segments")
public SuccessResponse reloadAllSegments(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Whether to force server to download segment")
@QueryParam("forceDownload") @DefaultValue("false") boolean forceDownload) {
Review comment:
The scenario we want to avoid is when the raw table name is provided,
and no table type is specified. We don't want to trigger the force download
reload on the realtime table, but only the offline table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
