klsince commented on a change in pull request #7249:
URL: https://github.com/apache/pinot/pull/7249#discussion_r685603526
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -472,13 +474,15 @@ public SuccessResponse reloadSegmentDeprecated2(
@ApiOperation(value = "Reload all segments", notes = "Reload all segments")
public SuccessResponse reloadAllSegments(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Whether to force server to download segment")
@QueryParam("forceDownload") @DefaultValue("false") boolean forceDownload) {
Review comment:
The target of this feature is to clean obsolete indices on disk, and
work for immutable segments from either realtime or offline table. But this PR
works with OFFLINE table only as it reuses the addOrReplaceOfflineSegment()
method, which assumes the segment is from OFFLINE table.
However, Jackie has opened a RP that removes limitations on ZKMetadata and
would allow me to converge the code path of segment downloading for both
Offline and Realtime table, and make this feature work with table types (sth I
plan to work on as next)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
