dongxiaoman commented on a change in pull request #7243:
URL: https://github.com/apache/pinot/pull/7243#discussion_r686531404
##########
File path:
pinot-broker/src/test/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerTest.java
##########
@@ -241,17 +242,17 @@ public void testPartitionAwareSegmentPruner(QueryCompiler
compiler) {
new PartitionSegmentPruner(OFFLINE_TABLE_NAME, PARTITION_COLUMN,
_propertyStore);
Set<String> onlineSegments = new HashSet<>();
segmentPruner.init(externalView, idealState, onlineSegments);
- assertEquals(segmentPruner.prune(brokerRequest1, Collections.emptySet()),
Collections.emptySet());
- assertEquals(segmentPruner.prune(brokerRequest2, Collections.emptySet()),
Collections.emptySet());
- assertEquals(segmentPruner.prune(brokerRequest3, Collections.emptySet()),
Collections.emptySet());
+ assertEquals(segmentPruner.prune(brokerRequest1, new
SelectedSegments(Collections.emptySet(), true)).getSegments(),
Collections.emptySet());
Review comment:
Lots of changes are due to the signature change.
We can avoid these changes by adding a "VisibleForTest" package private
wrapper to segmentPruner.
For now let's keep the changes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
