dongxiaoman commented on a change in pull request #7243:
URL: https://github.com/apache/pinot/pull/7243#discussion_r686935487
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/PartitionSegmentPruner.java
##########
@@ -151,10 +170,18 @@ public synchronized void refreshSegment(String segment) {
} else {
_partitionInfoMap.remove(segment);
}
+ rebuildReverseMap();
}
+// /**
+// * Package-level function to make previous tests happy
+// */
+// @VisibleForTesting
+// SelectedSegments prune(BrokerRequest brokerRequest, Set<String> segments) {
Review comment:
@Jackie-Jiang because of the signature change below, the Test has lots
of changes.
If we add a function here like the one in the comment, we can avoid lots of
changes in Test but this method will be only for testing simplicity.
I will remove this comment if we think the tests code change should be like
what we have now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
