jackjlli commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r709580103
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -298,10 +298,14 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
}
// Zk operations
- completeZkOperations(enableParallelPushProtection, headers,
finalSegmentFile, tableNameWithType, segmentMetadata,
- segmentName, zkDownloadUri, moveSegmentToFinalLocation,
crypterClassName);
-
- return new SuccessResponse("Successfully uploaded segment: " +
segmentName + " of table: " + tableNameWithType);
+ if (completeZkOperations(
+ enableParallelPushProtection, headers, finalSegmentFile,
tableNameWithType,
+ segmentMetadata, segmentName, zkDownloadUri,
moveSegmentToFinalLocation, crypterClassName)) {
+ return new SuccessResponse("Successfully uploaded segment: " +
segmentName + " of table: " + tableNameWithType);
+ } else {
+ return new SuccessResponse("Cannot replace non-existing segment,
aborted uploading segment: " + segmentName
Review comment:
And the controller metric `CONTROLLER_SEGMENT_UPLOAD_ERROR` might also
be required to update as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
