Jackie-Jiang commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r715001235
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java
##########
@@ -58,18 +58,25 @@ public ZKOperator(PinotHelixResourceManager
pinotHelixResourceManager, Controlle
_controllerMetrics = controllerMetrics;
}
- public void completeSegmentOperations(String tableNameWithType,
SegmentMetadata segmentMetadata,
+ public boolean completeSegmentOperations(String tableNameWithType,
SegmentMetadata segmentMetadata,
Review comment:
We are using exception to pass the failure information for
`processNewSegment()` and `processExistingSegment()`, so suggest directly
throwing exception if refreshing segment does not exist. Directly throwing
exception has the benefit of having more context info, and the accurate stack
trace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
